[LegalizeTypes] When promoting the result of EXTRACT_SUBVECTOR, also check if the...
authorCraig Topper <craig.topper@intel.com>
Fri, 22 Feb 2019 01:49:50 +0000 (01:49 +0000)
committerCraig Topper <craig.topper@intel.com>
Fri, 22 Feb 2019 01:49:50 +0000 (01:49 +0000)
commitbe22f329a957f507c6a695b0413e275506f5e122
tree22d7f286293fab4128f060e189523dd6e346f04c
parent4a7db8cb903696b83f6fd6c756c65946f6b5644b
[LegalizeTypes] When promoting the result of EXTRACT_SUBVECTOR, also check if the input needs to be promoted. Use that to determine the element type to extract.

Otherwise we end up creating extract_vector_elts that then each need to have their input promoted. This can lead to truncates needing to be emitted for each of those.

But we already emitted any_extends when we legalized the extract_subvector. So now we have pairs of any_extend+trunc that partially cancel. But depending on how DAGCombiner visits them we can get weird results.

By promoting the input at the same time we can create only a single any_extend or truncate.

There's one regression in the vector-narrow-binop.ll case, but that looks easy to fix with a follow up patch.

llvm-svn: 354647
llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
llvm/test/CodeGen/X86/2011-12-28-vselecti8.ll
llvm/test/CodeGen/X86/pr35918.ll
llvm/test/CodeGen/X86/vector-narrow-binop.ll