ALSA: usb-audio: Fix uninitialized variable at __uac_clock_find_source()
authorTakashi Iwai <tiwai@suse.de>
Thu, 20 May 2021 12:37:42 +0000 (14:37 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 21 May 2021 14:16:21 +0000 (16:16 +0200)
commitbe22db77dc50be6d9cf2b20ab689706c9031c054
treee052714e4349c71531856f9a0a7df9dacf303369
parentbdaedca74d6293b6ac643a8ebe8231b52bf1171b
ALSA: usb-audio: Fix uninitialized variable at __uac_clock_find_source()

The cur variable indicating the currently selected clock source can be
theoretically used as uninitialized after the recent commit
481f17c41803 ("ALSA: usb-audio: Handle error for the current selector
gracefully").  For addressing it, initialize it before use.

Also, one place seems setting 0 to a wrong variable ret, instead of
cur; otherwise it makes little sense.  Since the initialization is
done beforehand, we can get rid of this line, too.

Fixes: 481f17c41803 ("ALSA: usb-audio: Handle error for the current selector gracefully")
Reported-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/4b261d68-f53f-240d-2d8a-2f88b337849d@canonical.com
Link: https://lore.kernel.org/r/s5hfsyhh97t.wl-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/clock.c