[lldb] Fix that SIGWINCH crashes IOHandlerEditline when we are not using the editline...
authorRaphael Isemann <teemperor@gmail.com>
Fri, 19 Jun 2020 17:13:43 +0000 (19:13 +0200)
committerRaphael Isemann <teemperor@gmail.com>
Fri, 19 Jun 2020 17:14:16 +0000 (19:14 +0200)
commitbe18df3d23fe21fa622ec45fa09eddb3af3eef6b
treeb1e7842f7f51765dfb8aee230b9c6123b0e468a7
parent22d7a01dd7282ee5e70ce57a8c1465fd335ea27d
[lldb] Fix that SIGWINCH crashes IOHandlerEditline when we are not using the editline backend

Summary:
TerminalSizeChanged is called from our SIGWINCH signal handler but the
IOHandlerEditline currently doesn't check if we are actually using the real
editline backend. If we're not using the real editline backend, `m_editline_up`
won't be set and `IOHandlerEditline::TerminalSizeChanged` will access
the empty unique_ptr. In a real use case we don't use the editline backend
when we for example read input from a file. We also create some temporary
IOHandlerEditline's during LLDB startup it seems that are also treated
as non-interactive (apparently to read startup commands).

This patch just adds a nullptr check for`m_editline_up` as we do in the rest of
IOHandlerEditline.

Fixes rdar://problem/63921950

Reviewers: labath, friss

Reviewed By: friss

Subscribers: abidh, JDevlieghere

Differential Revision: https://reviews.llvm.org/D81729
lldb/source/Core/IOHandler.cpp
lldb/test/API/iohandler/resize/TestIOHandlerResizeNoEditline.py [new file with mode: 0644]