bfq-iosched: ensure to clear bic/bfqq pointers when preparing request
authorJens Axboe <axboe@kernel.dk>
Tue, 17 Apr 2018 23:08:52 +0000 (17:08 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 1 May 2018 19:58:19 +0000 (12:58 -0700)
commitbe10336a907253a6066d802c11b6edaf7cf397f8
treeea3d3d47084bb891cd84a0de7a10af73ae42044a
parentb23b4174275d397281023703ce19ff793e6dfd98
bfq-iosched: ensure to clear bic/bfqq pointers when preparing request

commit 72961c4e6082be79825265d9193272b8a1634dec upstream.

Even if we don't have an IO context attached to a request, we still
need to clear the priv[0..1] pointers, as they could be pointing
to previously used bic/bfqq structures. If we don't do so, we'll
either corrupt memory on dispatching a request, or cause an
imbalance in counters.

Inspired by a fix from Kees.

Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Reported-by: Kees Cook <keescook@chromium.org>
Cc: stable@vger.kernel.org
Fixes: aee69d78dec0 ("block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
block/bfq-iosched.c