nfsd: fix use-after-free in nfsd_file_do_acquire tracepoint
authorJeff Layton <jlayton@kernel.org>
Sat, 5 Nov 2022 13:49:26 +0000 (09:49 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Sat, 5 Nov 2022 15:29:55 +0000 (11:29 -0400)
commitbdd6b5624c62d0acd350d07564f1c82fe649235f
tree774b245113c2fdf51f0c82ca20aaa878ba679d38
parentd3aefd2b29ff5ffdeb5c06a7d3191a027a18cdb8
nfsd: fix use-after-free in nfsd_file_do_acquire tracepoint

When we fail to insert into the hashtable with a non-retryable error,
we'll free the object and then goto out_status. If the tracepoint is
enabled, it'll end up accessing the freed object when it tries to
grab the fields out of it.

Set nf to NULL after freeing it to avoid the issue.

Fixes: 243a5263014a ("nfsd: rework hashtable handling in nfsd_do_file_acquire")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/filecache.c