Add ath6kl cleaned up driver
authorKalle Valo <kvalo@qca.qualcomm.com>
Sun, 17 Jul 2011 21:22:30 +0000 (00:22 +0300)
committerKalle Valo <kvalo@qca.qualcomm.com>
Tue, 9 Aug 2011 16:45:18 +0000 (19:45 +0300)
commitbdcd81707973cf8aa9305337166f8ee842a050d4
treedf4ebda7e48afcd1e68d93d3d81a500e9c8c52a6
parentf749b94679c71a9c74ad9509dbbf00d8f3d620ad
Add ath6kl cleaned up driver

Last May we started working on cleaning up ath6kl driver which is
currently in staging. The work has happened in a separate
ath6kl-cleanup tree:

http://git.kernel.org/?p=linux/kernel/git/kvalo/ath6kl-cleanup.git;a=summary

After over 1100 (!) patches we have now reached a state where I would
like to start discussing about pushing the driver to the wireless
trees and replacing the staging driver.

The driver is now a lot smaller and looks like a proper Linux driver.
The size of the driver (measured with simple wc -l) dropped from 49
kLOC to 18 kLOC and the number of the .c and .h files dropped from 107
to 22. Most importantly the number of subdirectories reduced from 26
to zero :)

There are two remaining checkpatch warnings in the driver which we
decided to omit for now:

drivers/net/wireless/ath/ath6kl/debug.c:31:
  WARNING: printk() should include KERN_ facility level
drivers/net/wireless/ath/ath6kl/sdio.c:527:
  WARNING: msleep < 20ms can sleep for up to 20ms;
  see Documentation/timers/timers-howto.txt

The driver has endian annotations for all the hardware specific
structures and there are no sparse errors. Unfortunately I don't have
any big endian hardware to test that right now.

We have been testing the driver both on x86 and arm platforms. The
code is also compiled with sparc and parisc cross compilers.

Notable missing features compared to the current staging driver are:

o HCI over SDIO support
o nl80211 testmode
o firmware logging
o suspend support

Testmode, firmware logging and suspend support will be added soon. HCI
over SDIO support will be more difficult as the HCI driver needs to
share code with the wifi driver. This is something we need to research
more.

Also I want to point out the changes I did for signed endian support.
As I wasn't able to find any support for signed endian annotations I
decided to follow what NTFS has done and added my own. Grep for sle16
and sle32, especially from wmi.h.

Various people have been working on the cleanup, the hall of
fame based on number of patches is:

   543  Vasanthakumar Thiagarajan
   403  Raja Mani
   252  Kalle Valo
    16  Vivek Natarajan
    12  Suraj Sumangala
     3  Joe Perches
     2  Jouni Malinen

Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Signed-off-by: Raja Mani <rmani@qca.qualcomm.com>
Signed-off-by: Vivek Natarajan <nataraja@qca.qualcomm.com>
Signed-off-by: Suraj Sumangala <surajs@qca.qualcomm.com>
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
26 files changed:
drivers/net/wireless/ath/Kconfig
drivers/net/wireless/ath/Makefile
drivers/net/wireless/ath/ath6kl/Kconfig [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/Makefile [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/bmi.c [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/bmi.h [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/cfg80211.c [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/cfg80211.h [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/common.h [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/core.h [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/debug.c [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/debug.h [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/hif-ops.h [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/hif.h [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/htc.c [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/htc.h [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/htc_hif.c [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/htc_hif.h [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/init.c [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/main.c [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/node.c [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/sdio.c [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/target.h [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/txrx.c [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/wmi.c [new file with mode: 0644]
drivers/net/wireless/ath/ath6kl/wmi.h [new file with mode: 0644]