net/rds: Fix a use after free in rds_message_map_pages
authorLv Yunlong <lyl2019@mail.ustc.edu.cn>
Wed, 31 Mar 2021 01:59:59 +0000 (18:59 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 31 Mar 2021 21:26:56 +0000 (14:26 -0700)
commitbdc2ab5c61a5c07388f4820ff21e787b4dfd1ced
treee4de98593b2567237161731b200b533b4de41f87
parentd47ec7a0a7271dda08932d6208e4ab65ab0c987c
net/rds: Fix a use after free in rds_message_map_pages

In rds_message_map_pages, the rm is freed by rds_message_put(rm).
But rm is still used by rm->data.op_sg in return value.

My patch assigns ERR_CAST(rm->data.op_sg) to err before the rm is
freed to avoid the uaf.

Fixes: 7dba92037baf3 ("net/rds: Use ERR_PTR for rds_message_alloc_sgs()")
Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Reviewed-by: HÃ¥kon Bugge <haakon.bugge@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/rds/message.c