ath10k: Detect conf_mutex held ath10k_drain_tx() calls
authorShuah Khan <skhan@linuxfoundation.org>
Sat, 27 Feb 2021 00:07:00 +0000 (17:07 -0700)
committerIngo Molnar <mingo@kernel.org>
Sat, 6 Mar 2021 11:51:15 +0000 (12:51 +0100)
commitbdb1050ee1faaec1e78c15de8b1959176f26c655
tree931c522811a0a34b020ae4ed0b2d1044176e612e
parentf8cfa46608f8aa5ca5421ce281ab314129c15411
ath10k: Detect conf_mutex held ath10k_drain_tx() calls

ath10k_drain_tx() must not be called with conf_mutex held as workers can
use that also. Add call to lockdep_assert_not_held() on conf_mutex to
detect if conf_mutex is held by the caller.

The idea for this patch stemmed from coming across the comment block
above the ath10k_drain_tx() while reviewing the conf_mutex holds during
to debug the conf_mutex lock assert in ath10k_debug_fw_stats_request().

Adding detection to assert on conf_mutex hold will help detect incorrect
usages that could lead to locking problems when async worker routines try
to call this routine.

Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/linux-wireless/871rdmu9z9.fsf@codeaurora.org/
drivers/net/wireless/ath/ath10k/mac.c