ext4: zero out inline data using memset() instead of empty_zero_page
authorTheodore Ts'o <tytso@mit.edu>
Tue, 11 Dec 2012 08:31:49 +0000 (03:31 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 11 Dec 2012 08:31:49 +0000 (03:31 -0500)
commitbd9926e80330d43f15b710c2935fa41b792d56fd
treeccc30335831784996b7435d10df39ee14e92afad
parent9a4c8019471386c6fb039ae9e30f5216b6b55a9e
ext4: zero out inline data using memset() instead of empty_zero_page

Not all architectures (in particular, sparc64) have empty_zero_page.
So instead of copying from empty_zero_page, use memset to clear the
inline data by signalling to ext4_xattr_set_entry() via a magic
pointer value, EXT4_ZERO_ATTR_VALUE, which is defined by casting -1 to
a pointer.

This fixes a build failure on sparc64, and the memset() should be more
efficient than using memcpy() anyway.

Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/inline.c
fs/ext4/xattr.c
fs/ext4/xattr.h