video: fbdev: sm712fb: Fix crash in smtcfb_read()
authorHelge Deller <deller@gmx.de>
Sun, 27 Feb 2022 07:43:56 +0000 (08:43 +0100)
committerHelge Deller <deller@gmx.de>
Sun, 27 Feb 2022 07:43:56 +0000 (08:43 +0100)
commitbd771cf5c4254511cc4abb88f3dab3bd58bdf8e8
tree21186273f7b32374c7605edf9c85afbe3c9403bb
parent997403e7782a3b9aa6e2b28c6b78793659483af3
video: fbdev: sm712fb: Fix crash in smtcfb_read()

Zheyu Ma reported this crash in the sm712fb driver when reading
three bytes from the framebuffer:

 BUG: unable to handle page fault for address: ffffc90001ffffff
 RIP: 0010:smtcfb_read+0x230/0x3e0
 Call Trace:
  vfs_read+0x198/0xa00
  ? do_sys_openat2+0x27d/0x350
  ? __fget_light+0x54/0x340
  ksys_read+0xce/0x190
  do_syscall_64+0x43/0x90

Fix it by removing the open-coded endianess fixup-code and
by moving the pointer post decrement out the fb_readl() function.

Reported-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Tested-by: Zheyu Ma <zheyuma97@gmail.com>
Cc: stable@vger.kernel.org
drivers/video/fbdev/sm712fb.c