fs: fix generic save command implementation
authorStephen Warren <swarren@nvidia.com>
Mon, 3 Feb 2014 20:20:59 +0000 (13:20 -0700)
committerTom Rini <trini@ti.com>
Wed, 19 Feb 2014 14:47:33 +0000 (09:47 -0500)
commitbd6fb31fab1523ecac1aaf7af574868a26169dc6
tree00a06ba1a3cc5409caf3e45f188528809fe86337
parent16f4d9335fe18cf3b57e400baf7687f1c390fd8c
fs: fix generic save command implementation

Fix a few issues with the generic "save" shell command, and fs_write()
function.

1) fstypes[].write wasn't filled in for some file-systems, and isn't
   checked when used, which could cause crashes/... if executing save
   on e.g. fat/ext filesystems.

2) fs_write() requires the length argument to be non-zero, since it needs
   to know exactly how many bytes to write. Adjust the comments and code
   according to this.

3) fs_write() wasn't prototyped in <fs.h> like other generic functions;
   other code should be able to call this directly rather than invoking
   the "save" shell command.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Simon Glass <sjg@chromium.org>
fs/fs.c
include/fs.h