projects / platform / upstream / dotnet / runtime.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: d8b2120) | patch
Socket.Tests: remove TestSettings.UDPRedundancy (#44202)
authorAnton Firszov <Anton.Firszov@microsoft.com>
Wed, 4 Nov 2020 12:36:42 +0000 (13:36 +0100)
committerGitHub <noreply@github.com>
Wed, 4 Nov 2020 12:36:42 +0000 (13:36 +0100)
commitbd6c905df1710d919f88a8c2d9b573a04c8be58c
tree084fcff92ff9d540eb16802f54762883ccc3f0fbtree | snapshot
parentd8b2120df4759b050a50d88431777ae0870caac2commit | diff
Socket.Tests: remove TestSettings.UDPRedundancy  (#44202)

dotnet/corefx#15697 changed this value to 1, and no-one touched it since then.

As the comment in that PR points out, the root cause of the UDP test failures wasn't packet loss, but IPv4 / IPv6 port collision on Unix in dual-mode cases.

The value and the for loops are complicating Socket test code unnecessarily, simplification seems reasonable.
src/libraries/Common/tests/System/Net/Sockets/TestSettings.cs diff | blob | history
src/libraries/System.Net.Sockets/tests/FunctionalTests/DualModeSocketTest.cs diff | blob | history
src/libraries/System.Net.Sockets/tests/FunctionalTests/IPPacketInformationTest.cs diff | blob | history
src/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveMessageFrom.cs diff | blob | history
src/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveMessageFromAsync.cs diff | blob | history
src/libraries/System.Net.Sockets/tests/FunctionalTests/SelectAndPollTests.cs diff | blob | history
src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs diff | blob | history
src/libraries/System.Net.Sockets/tests/FunctionalTests/UdpClientTest.cs diff | blob | history
Domain: Dotnet / Core;