nfsd: fix potential race in nfs4_find_file
authorJeff Layton <jlayton@kernel.org>
Fri, 6 Jan 2023 15:33:48 +0000 (10:33 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 20 Feb 2023 14:20:22 +0000 (09:20 -0500)
commitbd6aaf781dae436727928cce514881d3c32758b9
tree1746c5eacc83d3074a4058b526b159a26a3c5f62
parent70f62231cdfd52357836733dd31db787e0412ab2
nfsd: fix potential race in nfs4_find_file

The WARN_ON_ONCE check is not terribly useful. It also seems possible
for nfs4_find_file to race with the destruction of an fi_deleg_file
while trying to take a reference to it.

Now that it's safe to pass nfs_get_file a NULL pointer, remove the WARN
and NULL pointer check. Take the fi_lock when fetching fi_deleg_file.

Cc: NeilBrown <neilb@suse.de>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4state.c