Stop test-in-container trying to run other-OS binaries.
authorJoseph Myers <joseph@codesourcery.com>
Tue, 4 Dec 2018 16:52:39 +0000 (16:52 +0000)
committerJoseph Myers <joseph@codesourcery.com>
Tue, 4 Dec 2018 16:52:39 +0000 (16:52 +0000)
commitbd598da9f454bc1091b4ebe0303b07e6f96ca130
tree6dd3f1e06e35840923c9a564d41e749802396788
parentb2e93de0ffedcfe2cfba100d47a4d4f6f85cea0b
Stop test-in-container trying to run other-OS binaries.

I noticed that, now that build-many-glibcs.py no longer copies glibc
sources, I was getting core dumps in my glibc source directories.  The
cause appears to be, from the i686-gnu build:

for dso in ` env LD_TRACE_LOADED_OBJECTS=1  \
        /scratch/jmyers/glibc-bot/build/glibcs/i686-gnu/glibc/elf/ld.so.1 \
        /scratch/jmyers/glibc-bot/build/glibcs/i686-gnu/glibc/testroot.pristine/bin/sh \
[...]
Segmentation fault (core dumped)

In this case, the x86 architecture means the binary executes, but
dumps core rather than actually working.

Anything involving running the newly built glibc should only be done
ifeq ($(run-built-tests),yes).  This patch conditions the relevant
part of the testroot setup accordingly.

Tested for x86_64, and with build-many-glibcs.py for i686-gnu.

* Makefile ($(objpfx)testroot.pristine/install.stamp): Do not run
dynamic linker unless [$(run-built-tests) = yes].
ChangeLog
Makefile