XArray: Fix xa_find_next for large multi-index entries
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Fri, 31 Jan 2020 10:07:55 +0000 (05:07 -0500)
committerMatthew Wilcox (Oracle) <willy@infradead.org>
Fri, 31 Jan 2020 20:09:36 +0000 (15:09 -0500)
commitbd40b17ca49d7d110adf456e647701ce74de2241
tree5b08f821b4204ae3698a8763f63a8d66b73da381
parentd5226fa6dbae0569ee43ecfc08bdcd6770fc4755
XArray: Fix xa_find_next for large multi-index entries

Coverity pointed out that xas_sibling() was shifting xa_offset without
promoting it to an unsigned long first, so the shift could cause an
overflow and we'd get the wrong answer.  The fix is obvious, and the
new test-case provokes UBSAN to report an error:
runtime error: shift exponent 60 is too large for 32-bit type 'int'

Fixes: 19c30f4dd092 ("XArray: Fix xa_find_after with multi-index entries")
Reported-by: Bjorn Helgaas <bhelgaas@google.com>
Reported-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: stable@vger.kernel.org
lib/test_xarray.c
lib/xarray.c