iwlwifi: mvm: avoid dumping assert log when device is stopped
authorSara Sharon <sara.sharon@intel.com>
Mon, 20 Nov 2017 16:02:05 +0000 (18:02 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Mar 2018 07:42:52 +0000 (08:42 +0100)
commitbd301e538bd65992fa9a2e539b2e3f642fc8e966
tree1d76743d636970b98760b2b660226eda3f46eaef
parente6fb81cb22b795219c1ed673d6532373569e1e53
iwlwifi: mvm: avoid dumping assert log when device is stopped

[ Upstream commit 6362ab721ef5c4ecfa01f53ad4137d3d984f0c6c ]

We might erroneously get to error dumping code when the
device is already stopped.

In that case the driver will detect a defective value and will try to
reset the HW, assuming it is only a bus issue.  The driver than
proceeds with the dumping.

The result has two side effects:

1. The device won't be stopped again, since the transport status is
already stopped, so the device remains powered on while it actually
should be stopped.

2. The dump in that case is completely garbaged and useless.

Detect and avoid this.  It will also make debugging such issues
easier.

Signed-off-by: Sara Sharon <sara.sharon@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/intel/iwlwifi/mvm/utils.c