Revert "macsec: missing dev_put() on error in macsec_newlink()"
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 16 Apr 2018 10:17:50 +0000 (13:17 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 16 Apr 2018 14:01:12 +0000 (10:01 -0400)
commitbd28899dd34f9283c567f7eeb31bb546f10820b5
treefcfed1bd77ffee1353967ac7aae1952ec327c1fc
parentc246fd333f84e6a0a8572f991637aa102f5e1865
Revert "macsec: missing dev_put() on error in macsec_newlink()"

This patch is just wrong, sorry.  I was trying to fix a static checker
warning and misread the code.  The reference taken in macsec_newlink()
is released in macsec_free_netdev() when the netdevice is destroyed.

This reverts commit 5dcd8400884cc4a043a6d4617e042489e5d566a9.

Reported-by: Laura Abbott <labbott@redhat.com>
Fixes: 5dcd8400884c ("macsec: missing dev_put() on error in macsec_newlink()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/macsec.c