Introduce [compat_]save_altstack_ex() to unbreak x86 SMAP
authorAl Viro <viro@ZenIV.linux.org.uk>
Sun, 1 Sep 2013 19:35:01 +0000 (20:35 +0100)
committerH. Peter Anvin <hpa@linux.intel.com>
Sun, 1 Sep 2013 21:16:33 +0000 (14:16 -0700)
commitbd1c149aa9915b9abb6d83d0f01dfd2ace0680b5
tree1ccdf876f778bd986a6238d379ee9e9981ed98dc
parent7263dda41b5a28ae6566fd126d9b06ada73dd721
Introduce [compat_]save_altstack_ex() to unbreak x86 SMAP

For performance reasons, when SMAP is in use, SMAP is left open for an
entire put_user_try { ... } put_user_catch(); block, however, calling
__put_user() in the middle of that block will close SMAP as the
STAC..CLAC constructs intentionally do not nest.

Furthermore, using __put_user() rather than put_user_ex() here is bad
for performance.

Thus, introduce new [compat_]save_altstack_ex() helpers that replace
__[compat_]save_altstack() for x86, being currently the only
architecture which supports put_user_try { ... } put_user_catch().

Reported-by: H. Peter Anvin <hpa@linux.intel.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: <stable@vger.kernel.org> # v3.8+
Link: http://lkml.kernel.org/n/tip-es5p6y64if71k8p5u08agv9n@git.kernel.org
arch/x86/ia32/ia32_signal.c
arch/x86/kernel/signal.c
include/linux/compat.h
include/linux/signal.h