anv: Add driconf option to disable compression for 16bpp format
authorSagar Ghuge <sagar.ghuge@intel.com>
Mon, 14 Sep 2020 22:52:11 +0000 (15:52 -0700)
committerMarge Bot <eric+marge@anholt.net>
Tue, 6 Oct 2020 18:27:25 +0000 (18:27 +0000)
commitbcfec61d1ee2675b8aaaf3adec8109ce6fa6c003
tree853fa7de97e0c9d376632c00c5add254c58deddb
parent49593205b980e95314b430e29d053056baad1d84
anv: Add driconf option to disable compression for 16bpp format

On Fallout4, enabling HIZ_CCS_WT compression for D16_UNORM format
regress the performance by 2%, in order to avoid that disable
compression via driconf option.

The experiment showed that, running Fallout4 with HIZ performs better
than HIZ_CCS and HIZ_CCS_WT. Reason behind that is the benchmark uses
the depth pass with D16_UNORM surfaces format which fills the L3 cache
and next pass doesn't make use of it where we end up clearing cache.

v2:
- Don't add conditional check in isl (Nanley, Jason)
- Move disable_d16unorm_compression flag to instance (Lionel)
- Use plane_format.isl_format (Nanley)

v3:
- Add more descriptive comment (Marcin Ĺšlusarz)

Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6734>
src/intel/vulkan/anv_device.c
src/intel/vulkan/anv_image.c
src/intel/vulkan/anv_private.h
src/util/00-mesa-defaults.conf
src/util/driconf.h