net: sctp: prevent writes to cookie_hmac_alg from accessing invalid memory
authorSasha Levin <sasha.levin@oracle.com>
Thu, 7 Jan 2016 19:52:43 +0000 (14:52 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 31 Jan 2016 19:23:36 +0000 (11:23 -0800)
commitbcea43fb3164cdcdc42c710ca0cb90aa9c6a5530
tree79dea2f1fad07c73c82dae498e9a5d343620a867
parenta33704eb60850ac837ef83ecc380f5f6b2aa2906
net: sctp: prevent writes to cookie_hmac_alg from accessing invalid memory

[ Upstream commit 320f1a4a175e7cd5d3f006f92b4d4d3e2cbb7bb5 ]

proc_dostring() needs an initialized destination string, while the one
provided in proc_sctp_do_hmac_alg() contains stack garbage.

Thus, writing to cookie_hmac_alg would strlen() that garbage and end up
accessing invalid memory.

Fixes: 3c68198e7 ("sctp: Make hmac algorithm selection for cookie generation dynamic")
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sctp/sysctl.c