selinux: check return value of sel_make_avc_files
authorChristian Göttsche <cgzones@googlemail.com>
Tue, 25 Jan 2022 14:14:20 +0000 (15:14 +0100)
committerPaul Moore <paul@paul-moore.com>
Wed, 26 Jan 2022 00:21:21 +0000 (19:21 -0500)
commitbcb62828e3e8c813b6613db6eb7fd9657db248fc
treefbd29194657e39ad936cd5722eee0da87a13941f
parent0266c25e7c2821181b610595df42cbca6bc93cb8
selinux: check return value of sel_make_avc_files

sel_make_avc_files() might fail and return a negative errno value on
memory allocation failures. Re-add the check of the return value,
dropped in 66f8e2f03c02 ("selinux: sidtab reverse lookup hash table").

Reported by clang-analyzer:

    security/selinux/selinuxfs.c:2129:2: warning: Value stored to
      'ret' is never read [deadcode.DeadStores]
            ret = sel_make_avc_files(dentry);
            ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 66f8e2f03c02 ("selinux: sidtab reverse lookup hash table")
Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
[PM: description line wrapping, added proper commit ref]
Signed-off-by: Paul Moore <paul@paul-moore.com>
security/selinux/selinuxfs.c