ext4: make sure quota gets properly shutdown on error
authorJan Kara <jack@suse.cz>
Thu, 7 Oct 2021 15:53:35 +0000 (17:53 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 10:05:15 +0000 (11:05 +0100)
commitbca8a2bfbdd0ebf13828d48c6e1acc2f658e04e1
tree99bd0292905b1d4d4bcde6863a03920dec17d44e
parent8ffe9ad9f5efc14a0d7a706ba3b8ee616b682872
ext4: make sure quota gets properly shutdown on error

commit 15fc69bbbbbc8c72e5f6cc4e1be0f51283c5448e upstream.

When we hit an error when enabling quotas and setting inode flags, we do
not properly shutdown quota subsystem despite returning error from
Q_QUOTAON quotactl. This can lead to some odd situations like kernel
using quota file while it is still writeable for userspace. Make sure we
properly cleanup the quota subsystem in case of error.

Signed-off-by: Jan Kara <jack@suse.cz>
Cc: stable@kernel.org
Link: https://lore.kernel.org/r/20211007155336.12493-2-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/super.c