rtlwifi: usb: allocate URB control message setup_packet and data buffer separately
authorJussi Kivilinna <jussi.kivilinna@mbnet.fi>
Mon, 18 Feb 2013 08:29:30 +0000 (10:29 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 18 Feb 2013 20:30:40 +0000 (15:30 -0500)
commitbc6b89237acb3dee6af6e64e51a18255fef89cc2
tree7a9d124856f3e1792c6e2272ad6c1464e3ffc705
parenta5f390562a375a315292648e2da865a12b42f280
rtlwifi: usb: allocate URB control message setup_packet and data buffer separately

rtlwifi allocates both setup_packet and data buffer of control message urb,
using shared kmalloc in _usbctrl_vendorreq_async_write. Structure used for
allocating is:
struct {
u8 data[254];
struct usb_ctrlrequest dr;
};

Because 'struct usb_ctrlrequest' is __packed, setup packet is unaligned and
DMA mapping of both 'data' and 'dr' confuses ARM/sunxi, leading to memory
corruptions and freezes.

Patch changes setup packet to be allocated separately.

[v2]:
 - Use WARN_ON_ONCE instead of WARN_ON

Cc: <stable@vger.kernel.org>
Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rtlwifi/usb.c