scsi: target: tcm_loop: Fix possible name leak in tcm_loop_setup_hba_bus()
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 15 Nov 2022 01:50:42 +0000 (09:50 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 17 Nov 2022 17:46:16 +0000 (17:46 +0000)
commitbc68e428d4963af0201e92159629ab96948f0893
tree4cc39ca754d03de7b6c6cd62df1a29eaf4bc6a8c
parent7d21fcfb409500dc9b114567f0ef8d30b3190dee
scsi: target: tcm_loop: Fix possible name leak in tcm_loop_setup_hba_bus()

If device_register() fails in tcm_loop_setup_hba_bus(), the name allocated
by dev_set_name() need be freed. As comment of device_register() says, it
should use put_device() to give up the reference in the error path. So fix
this by calling put_device(), then the name can be freed in kobject_cleanup().
The 'tl_hba' will be freed in tcm_loop_release_adapter(), so it don't need
goto error label in this case.

Fixes: 3703b2c5d041 ("[SCSI] tcm_loop: Add multi-fabric Linux/SCSI LLD fabric module")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221115015042.3652261-1-yangyingliang@huawei.com
Reviewed-by: Mike Christie <michael.chritie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/loopback/tcm_loop.c