btrfs: fix extent buffer leak after tree mod log failure at split_node()
authorFilipe Manana <fdmanana@suse.com>
Thu, 8 Jun 2023 10:27:38 +0000 (11:27 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Jul 2023 14:22:14 +0000 (16:22 +0200)
commitbc662a1e1f9faee90c914b39b5ee08f0e5fd5de4
tree65d8f8d0b74bd80e5fb719ff7b5b86bcf8eac0b7
parenta53d78d9a8551e72c46ded23e8b0a56e55d32032
btrfs: fix extent buffer leak after tree mod log failure at split_node()

commit ede600e497b1461d06d22a7d17703d9096868bc3 upstream.

At split_node(), if we fail to log the tree mod log copy operation, we
return without unlocking the split extent buffer we just allocated and
without decrementing the reference we own on it. Fix this by unlocking
it and decrementing the ref count before returning.

Fixes: 5de865eebb83 ("Btrfs: fix tree mod logging")
CC: stable@vger.kernel.org # 5.4+
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/btrfs/ctree.c