ARM: OMAP: DMA: use constant array maximum, drop some LCD DMA code
authorPaul Walmsley <paul@pwsan.com>
Fri, 13 Apr 2012 12:34:30 +0000 (06:34 -0600)
committerPaul Walmsley <paul@pwsan.com>
Fri, 13 Apr 2012 12:34:30 +0000 (06:34 -0600)
commitbc4d8b5f9f9dfe155f9e007739a5bb90f79db297
treedfb661f213783704ae3e3eb1bcffdb00aec89fd6
parent7cc0442cf2c2cc0efd117051d20e531f7cb2d604
ARM: OMAP: DMA: use constant array maximum, drop some LCD DMA code

gcc can apparently handle stack-allocated arrays that use a dynamic
variable as the array maximum.  Rather than using a mutable quantity,
simply use a constant maximum possible size.  To me, code clarity is
improved; and it also avoids the following sparse warnings:

arch/arm/plat-omap/dma.c:886:40: error: bad constant expression
arch/arm/plat-omap/dma.c:892:17: error: cannot size expression
arch/arm/plat-omap/dma.c:970:40: error: bad constant expression
arch/arm/plat-omap/dma.c:972:17: error: cannot size expression

Also drop some dead code from the OMAP1 LCD DMA code:

arch/arm/mach-omap1/lcd_dma.c:80:6: warning: symbol 'omap_set_lcd_dma_src_port' was not declared. Should it be static?

Signed-off-by: Paul Walmsley <paul@pwsan.com>
arch/arm/mach-omap1/lcd_dma.c
arch/arm/plat-omap/dma.c