[libc++][test] Fix iterator assertion in span.cons/deduct.pass.cpp
authorJoe Loser <joeloser93@gmail.com>
Wed, 22 Sep 2021 02:45:32 +0000 (22:45 -0400)
committerJoe Loser <joeloser93@gmail.com>
Wed, 22 Sep 2021 02:46:08 +0000 (22:46 -0400)
commitbc4a23811b021f4e5369162ed84f88a0240a81e2
treee418169fffb75362e61640f684751f429e0f03a7
parent4c2ee571482e066c0a524bd393a4c61aeaecff8a
[libc++][test] Fix iterator assertion in span.cons/deduct.pass.cpp

Two tests in span.cons/deduct.pass.cpp accidentally check whether the
iterator range from member begin and member end are equivalent to the
ones from free begin and free end. This is obviously true and not
intended. Correct the intent by comparing the size/data from the span
with the source input.

While in the neighborhood, add test for const int arr[N], remove extraneous
type aliases, unused <type_traits> header, and the
disable_missing_braces_warning.h include.

Reviewed By: Quuxplusone, ldionne, #libc

Differential Revision: https://reviews.llvm.org/D109668
libcxx/test/std/containers/views/span.cons/deduct.pass.cpp