audit: Use struct_size() helper in alloc_chunk
authorGustavo A. R. Silva <gustavoars@kernel.org>
Sun, 24 May 2020 20:52:38 +0000 (15:52 -0500)
committerPaul Moore <paul@paul-moore.com>
Wed, 17 Jun 2020 20:43:11 +0000 (16:43 -0400)
commitbbccc11bc8848926065915e6193fd4c6e33c85ef
tree87c2225344fc30b92dd8035e1ad10947359f7545
parentb3a9e3b9622ae10064826dccb4f7a52bd88c7407
audit: Use struct_size() helper in alloc_chunk

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct audit_chunk {
...
        struct node {
                struct list_head list;
                struct audit_tree *owner;
                unsigned index;         /* index; upper bit indicates 'will prune' */
        } owners[];
};

Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes.

So, replace the following form:

offsetof(struct audit_chunk, owners) + count * sizeof(struct node);

with:

struct_size(chunk, owners, count)

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Paul Moore <paul@paul-moore.com>
kernel/audit_tree.c