config-parser: Fail on impossible send_broadcast/send_destination pair
authorSimon McVittie <smcv@collabora.com>
Mon, 25 Sep 2017 12:37:56 +0000 (13:37 +0100)
committerSimon McVittie <smcv@collabora.com>
Mon, 25 Sep 2017 12:37:56 +0000 (13:37 +0100)
commitbbbc6023180b58b4ebe0c09afd8df8cf950cdb3b
tree1194213b195cef5d4cd6087a7893dd2e462b578d
parent8f9022e8dc6f181ae7b7af975d818f82a2a85a57
config-parser: Fail on impossible send_broadcast/send_destination pair

If we add a rule like

    <allow send_destination="com.example" send_broadcast="true"/>

then it cannot possibly match anything, because to be a broadcast, the
message would have to have no destination. The only value of
send_destination that can be combined with send_broadcast="true" is
the wildcard "*", but by this point in the function we already
replaced "*" with NULL.

Adapted from an earlier implementation of send_broadcast by
Alban Crequy.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Bug: https://bugs.freedesktop.org/92853
Reviewed-by: Philip Withnall <withnall@endlessm.com>
bus/config-parser.c