bpf, cgroup: Fix optlen WARN_ON_ONCE toctou
authorLoris Reiff <loris.reiff@liblor.ch>
Fri, 22 Jan 2021 16:42:31 +0000 (17:42 +0100)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 22 Jan 2021 22:11:34 +0000 (23:11 +0100)
commitbb8b81e396f7afbe7c50d789e2107512274d2a35
treecd23fb2afd862ab950fe23fb80ba8cc20ed37cb7
parent35c715c30b95205e64311c3bb3525094cd3d7236
bpf, cgroup: Fix optlen WARN_ON_ONCE toctou

A toctou issue in `__cgroup_bpf_run_filter_getsockopt` can trigger a
WARN_ON_ONCE in a check of `copy_from_user`.

`*optlen` is checked to be non-negative in the individual getsockopt
functions beforehand. Changing `*optlen` in a race to a negative value
will result in a `copy_from_user(ctx.optval, optval, ctx.optlen)` with
`ctx.optlen` being a negative integer.

Fixes: 0d01da6afc54 ("bpf: implement getsockopt and setsockopt hooks")
Signed-off-by: Loris Reiff <loris.reiff@liblor.ch>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Stanislav Fomichev <sdf@google.com>
Link: https://lore.kernel.org/bpf/20210122164232.61770-1-loris.reiff@liblor.ch
kernel/bpf/cgroup.c