drm/i915: Use drm_mode_init() for on-stack modes
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 18 Feb 2022 10:03:59 +0000 (12:03 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 5 May 2022 15:23:55 +0000 (18:23 +0300)
commitbb7acf59a11e013b5d548215918df9eb27dd35b2
treed97a32e6aeaf2d9e27ae4dcf1190e7fc676c38d2
parente0602d3a13e230fd5fb00236f7dc355f1447d8cb
drm/i915: Use drm_mode_init() for on-stack modes

Initialize on-stack modes with drm_mode_init() to guarantee
no stack garbage in the list head, or that we aren't copying
over another mode's list head.

Based on the following cocci script, with manual fixups:
@decl@
identifier M;
expression E;
@@
- struct drm_display_mode M = E;
+ struct drm_display_mode M;

@@
identifier decl.M;
expression decl.E;
statement S, S1;
@@
struct drm_display_mode M;
... when != S
+ drm_mode_init(&M, &E);
+
S1

@@
expression decl.E;
@@
- &*E
+ E

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220218100403.7028-19-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_display.c