HID: magicmouse: Do not set BTN_MOUSE on double report
authorJosé Expósito <jose.exposito89@gmail.com>
Sun, 9 Oct 2022 18:27:47 +0000 (20:27 +0200)
committerBenjamin Tissoires <benjamin.tissoires@redhat.com>
Fri, 14 Oct 2022 09:47:50 +0000 (10:47 +0100)
commitbb5f0c855dcfc893ae5ed90e4c646bde9e4498bf
tree6066299c5fd26caa71162e87438873c6dbbde3b8
parent79d11de9637a37035b4a72ccb528b3dfebc1bf67
HID: magicmouse: Do not set BTN_MOUSE on double report

Under certain conditions the Magic Trackpad can group 2 reports in a
single packet. The packet is split and the raw event function is
invoked recursively for each part.

However, after processing each part, the BTN_MOUSE status is updated,
sending multiple click events. [1]

Return after processing double reports to avoid this issue.

Link: https://gitlab.freedesktop.org/libinput/libinput/-/issues/811
Fixes: a462230e16ac ("HID: magicmouse: enable Magic Trackpad support")
Reported-by: Nulo <git@nulo.in>
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Link: https://lore.kernel.org/r/20221009182747.90730-1-jose.exposito89@gmail.com
drivers/hid/hid-magicmouse.c