Switch to vertex colors rather than uniforms for color in Ellipse/Circle/RRect/DRRect
authorbrianosman <brianosman@google.com>
Thu, 11 Feb 2016 22:15:18 +0000 (14:15 -0800)
committerCommit bot <commit-bot@chromium.org>
Thu, 11 Feb 2016 22:15:18 +0000 (14:15 -0800)
commitbb2ff94e223014403f775c3532a25cc25b00c949
treebbe0f8415c8a579e699a3ae56f4637330817c63e
parentd36f2c4bc047c2c531d73eee08daa5926e8cdaf2
Switch to vertex colors rather than uniforms for color in Ellipse/Circle/RRect/DRRect

[Notes:]
- Performance delta on desktop looked like noise. I'm curious what the results will be on low-end mobile GPUs. I'm still trying to figure out how I determine that with perf, etc...
- There appeared to be a single one-pixel image diff while running dm, if I'm understanding the results of skdiff correctly, so that's probably good news?
- Should I include anyone else on the review?

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1675833002

Review URL: https://codereview.chromium.org/1675833002
src/gpu/GrOvalRenderer.cpp