tipc: remove joining group member from congested list
authorJon Maloy <jon.maloy@ericsson.com>
Wed, 20 Dec 2017 10:03:15 +0000 (11:03 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 20 Dec 2017 19:56:48 +0000 (14:56 -0500)
commitbb25c3855a12cc58e33cd7ee9b69943790fe35f7
tree3844bdbeeebe378da5804ed7642dcbf427674ed3
parent1c8e77fb361a4a116a41ac1d9819eb79d068735d
tipc: remove joining group member from congested list

When we receive a JOIN message from a peer member, the message may
contain an advertised window value ADV_IDLE that permits removing the
member in question from the tipc_group::congested list. However, since
the removal has been made conditional on that the advertised window is
*not* ADV_IDLE, we miss this case. This has the effect that a sender
sometimes may enter a state of permanent, false, broadcast congestion.

We fix this by unconditinally removing the member from the congested
list before calling tipc_member_update(), which might potentially sort
it into the list again.

Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/group.c