xlnx_dp: fix iffy xlnx_dp_aux_push_tx_fifo
authorPaolo Bonzini <pbonzini@redhat.com>
Thu, 7 Jul 2016 12:47:00 +0000 (13:47 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Thu, 7 Jul 2016 12:47:00 +0000 (13:47 +0100)
commitbb14a1eda0d060413d17466c58b39e4c0dbcde4e
tree996aef5193299c4827cea6e22f1d6457a8a4704d
parent90e26f5aacd265257f7de58ee59f72dc36dff40e
xlnx_dp: fix iffy xlnx_dp_aux_push_tx_fifo

xlnx_dp_aux_push_tx_fifo takes an immediate uint8_t and a buffer length,
which must be 1 because that is how many uint8_t's fit in a uint8_t.
Sure enough, that is what xlnx_dp_write passes to it, but the function
is just weird.  Therefore, make xlnx_dp_aux_push_tx_fifo look like
xlnx_dp_aux_push_rx_fifo, taking a pointer to the buffer.

Reported by Coverity.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/display/xlnx_dp.c