writeback: Fix inode->i_io_list not be protected by inode->i_lock error
authorJchao Sun <sunjunchao2870@gmail.com>
Tue, 24 May 2022 15:05:40 +0000 (08:05 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 16:36:26 +0000 (18:36 +0200)
commitbafbc134f5b0948aa1ca015a0dff70b02c0152b7
tree7aa1b293e8fc05969388a7f4e25ac531778c233c
parentcba7c76ea1e15fddb95706eb64659644a6a02b38
writeback: Fix inode->i_io_list not be protected by inode->i_lock error

commit 10e14073107dd0b6d97d9516a02845a8e501c2c9 upstream.

Commit b35250c0816c ("writeback: Protect inode->i_io_list with
inode->i_lock") made inode->i_io_list not only protected by
wb->list_lock but also inode->i_lock, but inode_io_list_move_locked()
was missed. Add lock there and also update comment describing
things protected by inode->i_lock. This also fixes a race where
__mark_inode_dirty() could move inode under flush worker's hands
and thus sync(2) could miss writing some inodes.

Fixes: b35250c0816c ("writeback: Protect inode->i_io_list with inode->i_lock")
Link: https://lore.kernel.org/r/20220524150540.12552-1-sunjunchao2870@gmail.com
CC: stable@vger.kernel.org
Signed-off-by: Jchao Sun <sunjunchao2870@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/fs-writeback.c
fs/inode.c