dmaengine: dma-jz4780: Fix race in jz4780_dma_tx_status
authorPaul Cercueil <paul@crapouillou.net>
Sun, 4 Oct 2020 14:03:07 +0000 (16:03 +0200)
committerVinod Koul <vkoul@kernel.org>
Mon, 5 Oct 2020 04:28:48 +0000 (09:58 +0530)
commitbaf6fd97b16ea8f981b8a8b04039596f32fc2972
treeb999737798889eeb99d98737fec629a1b5ff96b6
parenta841592fb3a70bc3f3c2eaa2c1781479a52f76f9
dmaengine: dma-jz4780: Fix race in jz4780_dma_tx_status

The jz4780_dma_tx_status() function would check if a channel's cookie
state was set to 'completed', and if not, it would enter the critical
section. However, in that time frame, the jz4780_dma_chan_irq() function
was able to set the cookie to 'completed', and clear the jzchan->vchan
pointer, which was deferenced in the critical section of the first
function.

Fix this race by checking the channel's cookie state after entering the
critical function and not before.

Fixes: d894fc6046fe ("dmaengine: jz4780: add driver for the Ingenic JZ4780 DMA controller")
Cc: stable@vger.kernel.org # v4.0
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reported-by: Artur Rojek <contact@artur-rojek.eu>
Tested-by: Artur Rojek <contact@artur-rojek.eu>
Link: https://lore.kernel.org/r/20201004140307.885556-1-paul@crapouillou.net
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/dma-jz4780.c