nfc: llcp: fix possible use of uninitialized variable in nfc_llcp_send_connect()
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sat, 13 May 2023 11:52:04 +0000 (13:52 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Jul 2023 14:21:05 +0000 (16:21 +0200)
commitbac93b35f973c3db72129c0bf7cdd9f71a957a8f
tree1fb1cbbc1bc976cb3a8fa8a3a3074bf74dc0ca2c
parent34d04d70194d19ba9847400c12fcdeae6826630c
nfc: llcp: fix possible use of uninitialized variable in nfc_llcp_send_connect()

[ Upstream commit 0d9b41daa5907756a31772d8af8ac5ff25cf17c1 ]

If sock->service_name is NULL, the local variable
service_name_tlv_length will not be assigned by nfc_llcp_build_tlv(),
later leading to using value frmo the stack.  Smatch warning:

  net/nfc/llcp_commands.c:442 nfc_llcp_send_connect() error: uninitialized symbol 'service_name_tlv_length'.

Fixes: de9e5aeb4f40 ("NFC: llcp: Fix usage of llcp_add_tlv()")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/nfc/llcp_commands.c