crypto: lrw,xts - Replace strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Tue, 20 Jun 2023 20:08:32 +0000 (20:08 +0000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 14 Jul 2023 08:23:14 +0000 (18:23 +1000)
commitbabb80b3ecc6f40c962e13c654ebcd27f25ee327
treecb1073d1e5a21ebd3b802883f5c4fc9db1ef785b
parent31ba6dd2298fd9c49ecf66200103b1e88055f7a0
crypto: lrw,xts - Replace strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().

Direct replacement is safe here since return value of -errno
is used to check for truncation instead of sizeof(dest).

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/lrw.c
crypto/xts.c