x86/mm: Declare 'start' variable where it is used
authorLukas Bulwahn <lukas.bulwahn@gmail.com>
Mon, 28 Sep 2020 10:00:04 +0000 (12:00 +0200)
committerBorislav Petkov <bp@suse.de>
Fri, 20 Nov 2020 11:49:00 +0000 (12:49 +0100)
commitbab202ab87ba4da48018daf0f6810b22705a570d
tree2a7eeb0d9ccb6a951f3a7eb6bcfd606446c51c97
parent31d8546033053b98de00846ede8088bdbe38651d
x86/mm: Declare 'start' variable where it is used

It is not required to initialize the local variable start in
memory_map_top_down(), as the variable will be initialized in any path
before it is used.

make clang-analyzer on x86_64 tinyconfig reports:

  arch/x86/mm/init.c:612:15: warning: Although the value stored to 'start' \
  is used in the enclosing expression, the value is never actually read \
  from 'start' [clang-analyzer-deadcode.DeadStores]

Move the variable declaration into the loop, where it is used.

No code changed:

  # arch/x86/mm/init.o:

   text    data     bss     dec     hex filename
   7105    1424   26768   35297    89e1 init.o.before
   7105    1424   26768   35297    89e1 init.o.after

md5:
   a8d76c1bb5fce9cae251780a7ee7730f  init.o.before.asm
   a8d76c1bb5fce9cae251780a7ee7730f  init.o.after.asm

 [ bp: Massage. ]

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
Link: https://lkml.kernel.org/r/20200928100004.25674-1-lukas.bulwahn@gmail.com
arch/x86/mm/init.c