[OpenMP] Cleanup code
authorJonathan Peyton <jonathan.l.peyton@intel.com>
Thu, 9 Aug 2018 22:04:30 +0000 (22:04 +0000)
committerJonathan Peyton <jonathan.l.peyton@intel.com>
Thu, 9 Aug 2018 22:04:30 +0000 (22:04 +0000)
commitbaad3f6016b87cbd03578a1df6c6ea69280c4608
tree3e56c3fb3ee58e87ca95e731d4ed4ec9eec793c0
parent7da7b56830d94447e75479cbac71e5813496da38
[OpenMP] Cleanup code

This patch cleans up unused functions, variables, sign compare issues, and
addresses some -Warning flags which are now enabled including -Wcast-qual.
Not all the warning flags in LibompHandleFlags.cmake are enabled, but some
are with this patch.

Some __kmp_gtid_from_* macros in kmp.h are switched to static inline functions
which allows us to remove the awkward definition of KMP_DEBUG_ASSERT() and
KMP_ASSERT() macros which used the comma operator. This had to be done for the
innumerable -Wunused-value warnings related to KMP_DEBUG_ASSERT()

Differential Revision: https://reviews.llvm.org/D49105

llvm-svn: 339393
24 files changed:
openmp/runtime/cmake/LibompHandleFlags.cmake
openmp/runtime/cmake/config-ix.cmake
openmp/runtime/src/kmp.h
openmp/runtime/src/kmp_affinity.cpp
openmp/runtime/src/kmp_affinity.h
openmp/runtime/src/kmp_alloc.cpp
openmp/runtime/src/kmp_atomic.cpp
openmp/runtime/src/kmp_barrier.cpp
openmp/runtime/src/kmp_csupport.cpp
openmp/runtime/src/kmp_debug.h
openmp/runtime/src/kmp_dispatch.cpp
openmp/runtime/src/kmp_dispatch.h
openmp/runtime/src/kmp_gsupport.cpp
openmp/runtime/src/kmp_lock.cpp
openmp/runtime/src/kmp_lock.h
openmp/runtime/src/kmp_runtime.cpp
openmp/runtime/src/kmp_sched.cpp
openmp/runtime/src/kmp_settings.cpp
openmp/runtime/src/kmp_stub.cpp
openmp/runtime/src/kmp_tasking.cpp
openmp/runtime/src/kmp_wait_release.h
openmp/runtime/src/ompt-general.cpp
openmp/runtime/src/ompt-specific.h
openmp/runtime/src/thirdparty/ittnotify/ittnotify_static.c