[lldb] Don't check environment default char signedness when creating clang type for...
authorArthur Eubanks <aeubanks@google.com>
Sat, 15 Oct 2022 04:07:49 +0000 (21:07 -0700)
committerArthur Eubanks <aeubanks@google.com>
Thu, 20 Oct 2022 22:03:36 +0000 (15:03 -0700)
commitba8ded6820fa610c7460fe86cd1f41f1df4bcc6c
treee16e83e40dfa331a76509662d9d930afcce98ba5
parent2c82080f0964c45663d5599505e88f9124fc5f73
[lldb] Don't check environment default char signedness when creating clang type for "char"

With -f(un)signed-char, the die corresponding to "char" may be the opposite DW_ATE_(un)signed_char from the default platform signedness.
Ultimately we should determine whether a type is the unspecified signedness char by looking if its name is "char" (as opposed to "signed char"/"unsigned char") and not care about DW_ATE_(un)signed_char matching the platform default.

Fixes #23443

Reviewed By: labath

Differential Revision: https://reviews.llvm.org/D136011
lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
lldb/test/API/commands/expression/char/TestExprsChar.py
lldb/test/API/commands/expression/char/main.cpp