[FileCheck]] Canonicalize caret location testing
authorThomas Preud'homme <thomasp@graphcore.ai>
Tue, 23 Jul 2019 22:41:46 +0000 (22:41 +0000)
committerThomas Preud'homme <thomasp@graphcore.ai>
Tue, 23 Jul 2019 22:41:46 +0000 (22:41 +0000)
commitba4e8d791342219c072a5c8de8a3f41fbb53c6be
tree05357096137d10f2f4fbcb613dc34a6d6521126c
parent1b05977538d9487aa845ee2f3bec8b89c63c4f29
[FileCheck]] Canonicalize caret location testing

Summary:
Testing of caret location in diagnostic message is currently made with
CHECK directive with the following general format:
CHECK: {{^         \^$}}

James Henderson suggested the following would be more readable:
CHECK: {{^}}         ^{{$}}

and when whole lines can be matched (as is the case for command-line
testing where error messages do not include path):
CHECK:         ^
using the option --match-full-lines.

This commit implements these 2 changes on all existing caret position
tests. It also aligns the caret to the character it is trying to match
in the above line.

Reviewers: jhenderson, chandlerc, jdenny, probinson, grimar, arichardson, rnk

Subscribers: JonChesterfield, rogfer01, hfinkel, kristina, rnk, tra, arichardson, grimar, dblaikie, probinson, llvm-commits, hiraditya

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D64923

llvm-svn: 366861
llvm/test/FileCheck/check-not-diaginfo.txt
llvm/test/FileCheck/numeric-defines-diagnostics.txt
llvm/test/FileCheck/numeric-expression.txt
llvm/test/FileCheck/string-defines-diagnostics.txt
llvm/test/FileCheck/verbose.txt