serial: 8250_bcm2835aux: Add missing clk_disable_unprepare()
authorGuo Mengqi <guomengqi3@huawei.com>
Fri, 15 Jul 2022 02:33:12 +0000 (10:33 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Jul 2022 08:33:44 +0000 (10:33 +0200)
commitb9f1736e475dba0d6da48fdcb831248ab1597886
tree4d4084eff6b8671ea5a1be52b53fe35b81d8c11a
parentaf77c56aa35325daa2bc2bed5c2ebf169be61b86
serial: 8250_bcm2835aux: Add missing clk_disable_unprepare()

The error path when get clock frequency fails in bcm2835aux_serial
driver does not correctly disable the clock.

This flaw was found using a static analysis tool "Hulk Robot", which
reported the following warning when analyzing linux-next/master:

    drivers/tty/serial/8250/8250_bcm2835aux.c:
    warning: clk_disable_unprepare_missing.cocci

The cocci script checks for the existence of clk_disable_unprepare()
paired with clk_prepare_enable().

Add the missing clk_disable_unprepare() to the error path.

Fixes: fcc446c8aa63 ("serial: 8250_bcm2835aux: Add ACPI support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Guo Mengqi <guomengqi3@huawei.com>
Link: https://lore.kernel.org/r/20220715023312.37808-1-guomengqi3@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_bcm2835aux.c