ARM: 8720/1: ensure dump_instr() checks addr_limit
authorMark Rutland <mark.rutland@arm.com>
Thu, 2 Nov 2017 17:44:28 +0000 (18:44 +0100)
committerRussell King <rmk+kernel@armlinux.org.uk>
Mon, 6 Nov 2017 12:00:38 +0000 (12:00 +0000)
commitb9dd05c7002ee0ca8b676428b2268c26399b5e31
tree726645a75aa6e091da0ea05daa1c64f5d619bdf5
parentdad4675388fcb4353aea64174a165fb8494f1c13
ARM: 8720/1: ensure dump_instr() checks addr_limit

When CONFIG_DEBUG_USER is enabled, it's possible for a user to
deliberately trigger dump_instr() with a chosen kernel address.

Let's avoid problems resulting from this by using get_user() rather than
__get_user(), ensuring that we don't erroneously access kernel memory.

So that we can use the same code to dump user instructions and kernel
instructions, the common dumping code is factored out to __dump_instr(),
with the fs manipulated appropriately in dump_instr() around calls to
this.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: stable@vger.kernel.org
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
arch/arm/kernel/traps.c