tools lib subcmd: Make it an error to pass a signed value to OPTION_UINTEGER
authorArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 14 Feb 2017 16:55:40 +0000 (13:55 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 14 Feb 2017 18:19:17 +0000 (15:19 -0300)
commitb98897166280c4cfb9bc5a6c1b5682528eb4abff
treefefdb084b833c96bffc26a48224903c26bc3f395
parent49b3cd306e60b9d889c775cb2ebb709f80dd8ae9
tools lib subcmd: Make it an error to pass a signed value to OPTION_UINTEGER

Options marked OPTION_UINTEGER or OPTION_U64 clearly indicates that an
unsigned value is expected, so just error out when a negative value is
passed, instead of returning something undesired to the tool.

E.g.:

  # perf bench futex hash -t -4
  # Running 'futex/hash' benchmark:
   Error: switch `t' expects an unsigned numerical value
   Usage: perf bench futex hash <options>

      -t, --threads <n>     Specify amount of threads
  #

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Davidlohr Bueso <dbueso@suse.de>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-2mdn8s2raatyhz7tamrsz22r@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/lib/subcmd/parse-options.c