Revert r280137 and 280139 and subsequent build fixes
authorPavel Labath <labath@google.com>
Wed, 31 Aug 2016 08:43:37 +0000 (08:43 +0000)
committerPavel Labath <labath@google.com>
Wed, 31 Aug 2016 08:43:37 +0000 (08:43 +0000)
commitb9739d4090da7812e4a3ba2fccc357a76ee80bcb
tree5bc0712bb45db3a66d76b1f1aac45ff2e13de4a8
parentf21aade0d8d96417b4a7e25c7ddc300b0ea6d718
Revert r280137 and 280139 and subsequent build fixes

The rewrite of StringExtractor::GetHexMaxU32 changes functionality in a way which makes
lldb-server crash. The crash (assert) happens when parsing the "qRegisterInfo0" packet, because
the function tries to drop_front more bytes than the packet contains. It's not clear to me
whether we should consider this a bug in the caller or the callee, but it any case, it worked
before, so I am reverting this until we can figure out what the proper interface should be.

llvm-svn: 280207
lldb/include/lldb/Core/ArchSpec.h
lldb/include/lldb/Interpreter/Args.h
lldb/include/lldb/Utility/StringExtractor.h
lldb/source/Core/ArchSpec.cpp
lldb/source/Interpreter/Args.cpp
lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
lldb/source/Utility/StringExtractor.cpp
lldb/unittests/Utility/StringExtractorTest.cpp