sched: Remove pointless preemption disable in sched_submit_work()
authorThomas Gleixner <tglx@linutronix.de>
Wed, 29 Sep 2021 09:37:32 +0000 (11:37 +0200)
committerPeter Zijlstra <peterz@infradead.org>
Tue, 5 Oct 2021 13:52:15 +0000 (15:52 +0200)
commitb945efcdd07d86cece1cce68503aae91f107eacb
tree4e09be569b7976c2b04bcda0e7d72d9de699c41d
parent670721c7bd2a6e16e40db29b2707a27bdecd6928
sched: Remove pointless preemption disable in sched_submit_work()

Neither wq_worker_sleeping() nor io_wq_worker_sleeping() require to be invoked
with preemption disabled:

  - The worker flag checks operations only need to be serialized against
    the worker thread itself.

  - The accounting and worker pool operations are serialized with locks.

which means that disabling preemption has neither a reason nor a
value. Remove it and update the stale comment.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Lai Jiangshan <jiangshanlai@gmail.com>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Link: https://lkml.kernel.org/r/8735pnafj7.ffs@tglx
kernel/sched/core.c