slcan: Don't transmit uninitialized stack data in padding
authorRichard Palethorpe <rpalethorpe@suse.com>
Wed, 1 Apr 2020 10:06:39 +0000 (12:06 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 1 Apr 2020 18:22:35 +0000 (11:22 -0700)
commitb9258a2cece4ec1f020715fe3554bc2e360f6264
treec3f4ccfcf5a08a328d39a1f839e1b482e57cc7bc
parentb1f4c209d84057b6d40b939b6e4404854271d797
slcan: Don't transmit uninitialized stack data in padding

struct can_frame contains some padding which is not explicitly zeroed in
slc_bump. This uninitialized data will then be transmitted if the stack
initialization hardening feature is not enabled (CONFIG_INIT_STACK_ALL).

This commit just zeroes the whole struct including the padding.

Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
Fixes: a1044e36e457 ("can: add slcan driver for serial/USB-serial CAN adapters")
Reviewed-by: Kees Cook <keescook@chromium.org>
Cc: linux-can@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: security@kernel.org
Cc: wg@grandegger.com
Cc: mkl@pengutronix.de
Cc: davem@davemloft.net
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/can/slcan.c