Revert "[gn build] Don't set LLVM_UNREACHABLE_OPTIMIZE when llvm_enable_assertions"
authorArthur Eubanks <aeubanks@google.com>
Mon, 10 Oct 2022 22:18:43 +0000 (15:18 -0700)
committerArthur Eubanks <aeubanks@google.com>
Mon, 10 Oct 2022 22:20:53 +0000 (15:20 -0700)
commitb8e71766c835603b6353827dc54939e1740f4867
treeba6ce78add63128cb02100deef473a3fb5fb546e
parent7639ba690648fae2b2034aa842942419b2fdcad4
Revert "[gn build] Don't set LLVM_UNREACHABLE_OPTIMIZE when llvm_enable_assertions"

This reverts commit 0f19c603423e28ab663c1fdff2048c555abe5f6d.

This didn't actually do anything. llvm_unreachable() under `#ifndef NDEBUG` is always supposed to report an error regardless of LLVM_UNREACHABLE_OPTIMIZE. I can't reproduce the issue I was originally seeing with this reverted, not sure what was happening back then, manually verified by messing around with various binaries/configurations.
llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn